Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump sphinx dependency #3441

Merged
merged 12 commits into from
Jan 15, 2023
Merged

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Jan 11, 2023

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: Bump Sphinx dependency as it was causing issues during CI.

Additionally adds the py dependency as the latest pytest version (7.2.1, released today) contains a change that breaks the pytest-benchmark dependency. See pytest-dev/pytest#10420 for more details.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 changed the title chore: Update sphinx ci: Update sphinx Jan 14, 2023
@felixwang9817 felixwang9817 changed the title ci: Update sphinx ci: Remove sphinx dependency Jan 14, 2023
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 changed the title ci: Remove sphinx dependency ci: Bump sphinx dependency Jan 15, 2023
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 38d5534 into feast-dev:master Jan 15, 2023
@felixwang9817 felixwang9817 deleted the update_sphinx branch January 15, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants