Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Dragonfly as an online-store option to Feast Readme and docs #3647

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

yirenlu92
Copy link
Contributor

What this PR does / why we need it:
Adds Dragonfly (drop in Redis replacement as an online-store option)

Which issue(s) this PR fixes:

Fixes #

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yirenlu92
To complete the pull request process, please assign mattdelac after the PR has been reviewed.
You can assign the PR to them by writing /assign @mattdelac in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yirenlu92 yirenlu92 changed the title Add Dragonfly as an online-store option to Feast Readme and docs docs: Add Dragonfly as an online-store option to Feast Readme and docs Jun 8, 2023
@worldsoup
Copy link

hey @adchia just wanted to ping you on this...any changes needed to get this docs update merged? Thanks in advance

@adchia
Copy link
Collaborator

adchia commented Aug 16, 2023

Hey! Sorry for the delay. Looks like you manually modified the README, but actually you should be using make build-templates to generate the README (+ changing https://github.com/feast-dev/feast/blob/master/infra/templates/README.md.jinja2)

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it for you.

/lgtm

yirenlu92 and others added 4 commits September 5, 2023 00:18
Signed-off-by: Danny C <d.chiao@gmail.com>
Signed-off-by: Danny C <d.chiao@gmail.com>
Signed-off-by: Danny C <d.chiao@gmail.com>
Signed-off-by: Danny C <d.chiao@gmail.com>
@adchia adchia merged commit 377758b into feast-dev:master Sep 5, 2023
12 of 13 checks passed
@Niennienzz
Copy link

Niennienzz commented Sep 5, 2023

Hi @adchia, thank you for reviewing!

I am wondering when/how will the Dragonfly page actually land in the Feast doc?

@adchia
Copy link
Collaborator

adchia commented Sep 5, 2023

i'll cut a release soon and then it'll show up!

@Niennienzz
Copy link

i'll cut a release soon and then it'll show up!

Got it, thank you sooo much!

james-crabtree-sp pushed a commit to sailpoint/feast that referenced this pull request Sep 14, 2023
feast-dev#3647)

* Add dragonfly to feast Readme and docs

Signed-off-by: Danny C <d.chiao@gmail.com>

* Remove new lines

Signed-off-by: Danny C <d.chiao@gmail.com>

* Remove more newlines

Signed-off-by: Danny C <d.chiao@gmail.com>

* rebase and fix using template generation

Signed-off-by: Danny C <d.chiao@gmail.com>

---------

Signed-off-by: Danny C <d.chiao@gmail.com>
Co-authored-by: Danny C <d.chiao@gmail.com>
james-crabtree-sp pushed a commit to sailpoint/feast that referenced this pull request Sep 14, 2023
feast-dev#3647)

* Add dragonfly to feast Readme and docs

Signed-off-by: Danny C <d.chiao@gmail.com>

* Remove new lines

Signed-off-by: Danny C <d.chiao@gmail.com>

* Remove more newlines

Signed-off-by: Danny C <d.chiao@gmail.com>

* rebase and fix using template generation

Signed-off-by: Danny C <d.chiao@gmail.com>

---------

Signed-off-by: Danny C <d.chiao@gmail.com>
Co-authored-by: Danny C <d.chiao@gmail.com>
zseta pushed a commit to zseta/feast that referenced this pull request Feb 7, 2024
feast-dev#3647)

* Add dragonfly to feast Readme and docs

Signed-off-by: Danny C <d.chiao@gmail.com>

* Remove new lines

Signed-off-by: Danny C <d.chiao@gmail.com>

* Remove more newlines

Signed-off-by: Danny C <d.chiao@gmail.com>

* rebase and fix using template generation

Signed-off-by: Danny C <d.chiao@gmail.com>

---------

Signed-off-by: Danny C <d.chiao@gmail.com>
Co-authored-by: Danny C <d.chiao@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants