Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Monitoring for Feast Feature Store (python server) #4252

Closed
wants to merge 1 commit into from

Conversation

tsisodia10
Copy link
Contributor

What this PR does / why we need it:

This draft pull request introduces monitoring functionality for the Feast feature store(python server). It instruments the feature store to capture system-level metrics, currently focusing on CPU and memory usage. Additionally, this PR includes the setup for a Prometheus server to collect and store these metrics.

Note: This pull request is currently a work in progress.

@tsisodia10 tsisodia10 changed the title Monitoring for Feast Feature Store (python server) feat: Monitoring for Feast Feature Store (python server) Jun 4, 2024
@shuchu
Copy link
Collaborator

shuchu commented Jun 4, 2024

Is it possible to use open-telemetry client for instrumentation?

@jeremyary
Copy link
Collaborator

@shuchu we'll definitely do some investigating! We're not necessarily opposed to proper abstraction that could bridge components or something similarly if need be down the road. I saw that it's the second most-active CNCF project so I'm guessing it's fairly popular :)

@shuchu
Copy link
Collaborator

shuchu commented Jun 5, 2024

@shuchu we'll definitely do some investigating! We're not necessarily opposed to proper abstraction that could bridge components or something similarly if need be down the road. I saw that it's the second most-active CNCF project so I'm guessing it's fairly popular :)

Thank you Jeremy. The Open-telemetry seems to be a "standard" service for many companies. I thought it not only can benefit the Feast but also the Red Hat's OpenShift (https://www.redhat.com/en/technologies/cloud-computing/openshift/observability).

@tsisodia10
Copy link
Contributor Author

Thanks @shuchu for the recommendation, that sounds like a great idea and we are looking into the implementation.

@shuchu
Copy link
Collaborator

shuchu commented Jun 6, 2024

Thanks @shuchu for the recommendation, that sounds like a great idea and we are looking into the implementation.

Thank you @tsisodia10 !

Signed-off-by: Twinkll Sisodia <tsisodia@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants