Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add parameters validation to OfflineServer #4289

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

tmihalac
Copy link
Contributor

This PR adds parameters validation to the remote offline store server.

Which issue(s) this PR fixes:
Enhances #4032

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
@tmihalac tmihalac changed the title Add parameters validation to OfflineServer refactor: Add parameters validation to OfflineServer Jun 17, 2024
Copy link
Contributor

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@tokoko tokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeremyary jeremyary merged commit de5b0eb into feast-dev:master Jun 20, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants