fix: Fix SQLite import issue #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojavierarceo
changed the title
franciscojavierarceo
changed the title
franciscojavierarceo
force-pushed
the
sqlite-vec-patch
branch
from
66cf0a4
to
66a5c71
Compare
tokoko
reviewed
Jul 1, 2024
| @@ -410,6 +412,10 @@ def retrieve_online_documents( | |||
|
|
|||
|
|
|||
| def _initialize_conn(db_path: str): | |||
| try: | |||
| import sqlite_vec # noqa: F401 | |||
There was a problem hiding this comment.
Is this import used anywhere?
There was a problem hiding this comment.
yeah that code already exists
HaoXuAI
approved these changes
Jul 1, 2024
|
nice |
franciscojavierarceo
added a commit
that referenced
this pull request
Jul 4, 2024
adding try and except block for import Co-authored-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
franciscojavierarceo
pushed a commit
that referenced
this pull request
Jul 4, 2024
## [0.39.1](v0.39.0...v0.39.1) (2024-07-04) ### Bug Fixes * Fix SQLite import issue ([#4294](#4294)) ([8d9b60e](8d9b60e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds try/except block to importing
sqlite_vecWhich issue(s) this PR fixes:
#4293
Fixes
#4293