Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native types for Python SDK online retrieval #826

Merged
merged 21 commits into from
Jun 30, 2020

Conversation

terryyylim
Copy link
Member

@terryyylim terryyylim commented Jun 25, 2020

What this PR does / why we need it:
Allows user to pass in a more readable form of EntityRow, using Python native form, for get_online_features method. Also, users are now able to convert the response in a more readable form by using to_dict().

Which issue(s) this PR fixes:

Fixes #766

Does this PR introduce a user-facing change?:

Users can now use `to_dict()` after getting the response from python SDK's get_online_features to convert response to a more human readable form.

@woop
Copy link
Member

woop commented Jun 25, 2020

Allows user to pass in a more readable form of EntityRow

Does this PR introduce a user-facing change?: NONE

Seems contradictory x_X

@woop
Copy link
Member

woop commented Jun 25, 2020

Please update the Gitbook examples and tutorials as well to this new format.

sdk/python/feast/client.py Outdated Show resolved Hide resolved
sdk/python/feast/client.py Outdated Show resolved Hide resolved
@terryyylim terryyylim changed the title Add native types for Python SDK get_online_features Add native types for Python SDK online retrieval Jun 25, 2020
@terryyylim
Copy link
Member Author

/retest

sdk/python/feast/client.py Outdated Show resolved Hide resolved
sdk/python/feast/client.py Outdated Show resolved Hide resolved
sdk/python/feast/client.py Outdated Show resolved Hide resolved
sdk/python/feast/client.py Outdated Show resolved Hide resolved
@terryyylim
Copy link
Member Author

/retest

@terryyylim
Copy link
Member Author

/test test-end-to-end

sdk/python/feast/client.py Outdated Show resolved Hide resolved
sdk/python/feast/type_map.py Outdated Show resolved Hide resolved
sdk/python/feast/client.py Outdated Show resolved Hide resolved
examples/basic/basic.ipynb Outdated Show resolved Hide resolved
@terryyylim
Copy link
Member Author

/test test-end-to-end-auth

1 similar comment
@terryyylim
Copy link
Member Author

/test test-end-to-end-auth

@terryyylim
Copy link
Member Author

/test test-end-to-end-auth

sdk/python/feast/client.py Outdated Show resolved Hide resolved
sdk/python/feast/client.py Outdated Show resolved Hide resolved
sdk/python/feast/response.py Outdated Show resolved Hide resolved
@terryyylim
Copy link
Member Author

/test test-end-to-end-auth

@woop
Copy link
Member

woop commented Jun 30, 2020

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terryyylim, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 9f35706 into feast-dev:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate SDKs to use Native types instead of Protobuf types
4 participants