Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobCoordinator may be turned off by configuration #829

Merged

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Jun 25, 2020

What this PR does / why we need it:

We need option to deploy core without job management

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Added the option of turning ingestion job management on or off.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jun 25, 2020

/lgtm

@woop
Copy link
Member

woop commented Jun 25, 2020

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Jun 25, 2020
@feast-ci-bot feast-ci-bot merged commit 197a701 into feast-dev:master Jun 25, 2020
@ches
Copy link
Member

ches commented Jul 4, 2020

We pretty much coincidentally implemented the same thing at the same time.

Illuminating a use case for anyone following along: you probably want to deploy redundant Core instances for availability. They will not play well together if they all try to manage jobs, duplicating things and stomping on each other.

A boolean flag serves as poor man's leader election, enable it on only one instance in a deployment. If the active coordinator fails, remediate by bringing it back to life or deploying a new instance with this flag enabled.

Although not specific to the job coordination, a related concern is that Serving instances talk to Core to load and cache registered feature set specifications. The caching provides a layer of resilience if Core instances fail. Enabling a means of load balancing / round-robin for the gRPC connections from Serving to Core instances may be desirable however.

Some of this may have a home in Feast operations guide documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants