-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impute default project if empty before authorization is called #926
Impute default project if empty before authorization is called #926
Conversation
Hi @jmelinav. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc997fb
to
041083a
Compare
/assign @pyalex |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmelinav, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@jmelinav: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
/lgtm |
What this PR does / why we need it:
if
project
is not set in thefeatureSet
, which is in the request forapplyFeatureSet
method, an empty project will be passed for authorization. Instead it should authorize againstdefault
project.Which issue(s) this PR fixes:
Related to #793
Does this PR introduce a user-facing change?:no