Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Make the Access Token drawer style consistent #335

Closed
deleteLater opened this issue Apr 26, 2023 · 4 comments · Fixed by #346
Closed

[Good First Issue]: Make the Access Token drawer style consistent #335

deleteLater opened this issue Apr 26, 2023 · 4 comments · Fixed by #346
Assignees
@mucoban
Labels
angular good first issue Good for newcomers help wanted Extra attention is needed points:4

Comments

@deleteLater
Copy link
Contributor

deleteLater commented Apr 26, 2023 •
edited

Description

The current style of the Access Token drawer does not meet our design standards. To fix this, two tasks need to be done:

  • Update the save button style to match the rest of the application.
  • Change the drawer width from 700 to 500.

Scope

  • Service: UI
  • Component: Access Token drawer component
  • Location: modules/front-end/src/app/core/components/access-token-drawer

To make the save button style consistent with others, we should place the save button in the nzDrawerContent element instead of the footer element. Just like how policy drawer does here.

Screenshot

Current

image

Expected

image

Setup dev environment

Please read the doc to set up your development environment.

Deadline

We usually give 2 weeks for a feature request, which means you have 2 weeks to implement the feature starting from the
day it is assigned to you. If you have any difficulties, please contact us in Slack.

How to implement

  1. Fork the FeatBit repository.
  2. Create a branch issues-{issues number}
  3. Implement the task based on Description and Scope mentioned above.
  4. Submit your PR

Make sure you complete the following tasks before submit your PR

  • merge featbit main branch into your working branch
  • run npm run i18n
  • commit messages.xlf & messages.zh.xlf file changes

Contribution points

Each contribution counts a certain number of points, depending on its difficulty. Contributors earn the appropriate
points when the work is merged. Contribution points are used to describe the contributions that contributors have made.
They can also be used to receive rewards for community events. You can view the current community submissions on a
public google sheet.

Points: 4

How to claim to solve the issue

If you want to implement this function, please leave a comment in this issue like:

I'd like to implement this function, please assign this issue to me.
@deleteLater deleteLater added good first issue Good for newcomers help wanted Extra attention is needed points:4 ui angular and removed ui labels Apr 26, 2023
@mucoban
Copy link
Contributor

mucoban commented May 1, 2023

I'd like to implement this function, please assign this issue to me.

@deleteLater
Copy link
Contributor Author

Thanks @mucoban 🤝 I've assigned this issue to you.

mucoban added a commit to mucoban/featbit that referenced this issue May 4, 2023
@mucoban
fix:change th drawer width from 700 to 500 and position of submit but…
bf0a1ef 
…ton in access token drawer(featbit#335)
@mucoban
Copy link
Contributor

mucoban commented May 4, 2023

I created the pr. Can you review?

@deleteLater deleteLater mentioned this issue May 5, 2023
Merged
mucoban added a commit to mucoban/featbit that referenced this issue May 5, 2023
@mucoban
messages.xlf & messages.zh.xlf file changes and delete footer template(…
e4cb74a 
…featbit#335)
@mucoban
Copy link
Contributor

mucoban commented May 5, 2023

hi, I pushed a commit upon your comments

mucoban added a commit to mucoban/featbit that referenced this issue May 6, 2023
@mucoban
submit button moved under Permissions(featbit#335)
f30868d
mucoban added a commit to mucoban/featbit that referenced this issue May 8, 2023
@mucoban
make permissions a div again(featbit#335)
417e652
deleteLater pushed a commit that referenced this issue May 9, 2023
@mucoban
🧹 refactor: make the access token drawer style consistent (#346)
edc19ea 
* fix:change th drawer width from 700 to 500 and position of submit button in access token drawer(#335)

* messages.xlf & messages.zh.xlf file changes and delete footer template(#335)

* submit button moved under Permissions(#335)

* make permissions a div again(#335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mucoban mucoban

Labels
angular good first issue Good for newcomers help wanted Extra attention is needed points:4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🧹 refactor: make the access token drawer style consistent mucoban/featbit
2 participants
@deleteLater @mucoban