🐛 fix: type mismatch in instantiating feature flag filter from query string #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmos-explorer
approved these changes
Jul 3, 2023
mucoban
pushed a commit
to mucoban/featbit
that referenced
this pull request
Jul 12, 2023
…string (featbit#430) * fix * update i18n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue in the feature flag index page that occurs when loading the page with a query string.
The query string is used to instantiate the feature flag filter, but the extracted values are treated as strings, causing type mismatch problems. For example, when the query string contains
?isArchived=false, the value offilter.isArchivedis parsed as a string "false", so conditional checks like*ngIf="filter.isArchived"will evaluate to true, which is not the intended behavior.