🐛 fix: organization name doesn't update after another user update it … #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,21 +67,12 @@ export class OrganizationService { | |||
|
|
|||
| getCurrentOrganization(): Observable<IOrganization> { | |||
| return new Observable(observer => { | |||
| const orgStr = localStorage.getItem(CURRENT_ORGANIZATION()); | |||
| if (this.organizations.length === 0 || !orgStr || JSON.parse(orgStr)?.plan === undefined) { | |||
There was a problem hiding this comment.
this changes removed a feature: when one user has more than one organization, when he logout and then login again, the original code would keep the user loging into the same org.
There was a problem hiding this comment.
I would suggest this change:
There was a problem hiding this comment.
If the org data exists in localstorage, we take it (with the latest data from backend) otherwise, we would take the first one of the organization list
There was a problem hiding this comment.
I pushed a commit applying your suggestion
|
@mucoban can you resolve the conflicts? |
|
I resolved the conflicts @cosmos-explorer |
cosmos-explorer
approved these changes
Jul 14, 2023
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCurrentOrganization() method checks if organization data exits in local storage. If it doesn't exist, fetches organization data from api and saves it to local storage. This causes the organization name to remain same after another user changes it if there is organization data which is saved is local storage already.
I canceled local storage check for organization data in getCurrentOrganization() method, and therefore the getCurrentOrganization() fetches organization data from api on page load, even if it is saved in local storage.
Screen.Recording.2023-07-05.at.19.44.26.mov
fixed #331