Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 refactor: replace class-based resolvers with functional resolvers #441

Merged
merged 8 commits into from
Jul 11, 2023

Conversation

cosmos-explorer
Copy link
Contributor

Resolve is deprecated and will be removed in Angular 17, the prefered way is the ResolveFn

Copy link
Contributor

@deleteLater deleteLater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deleteLater deleteLater changed the title 🧹Debt/clean 🧹 refactor: replace deprecated resolvers Jul 11, 2023
@deleteLater deleteLater changed the title 🧹 refactor: replace deprecated resolvers 🧹 refactor: replace class-based resolvers with functional resolvers Jul 11, 2023
@deleteLater deleteLater merged commit 310387e into main Jul 11, 2023
1 check passed
@deleteLater deleteLater deleted the debt/clean branch July 11, 2023 05:31
mucoban pushed a commit to mucoban/featbit that referenced this pull request Jul 12, 2023
…eatbit#441)

* debt: code clean

* Update account-preject-env-resolver.service.ts

* replace resolve by ResolveFn

* replaced Resolve by ResolveFn 2

* clean

* refactor

* more clean

* rename

---------

Co-authored-by: deleteLater <mikcczhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants