Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃Ч refactor: code clean for front end project #443

Merged
merged 13 commits into from
Jul 14, 2023
Merged

馃Ч refactor: code clean for front end project #443

merged 13 commits into from
Jul 14, 2023

Conversation

deleteLater
Copy link
Contributor

@deleteLater deleteLater commented Jul 11, 2023 •
edited

This PR

  • remove unused code
  • remove getCurrentOrganizationProjectEnv method
  • refactor the way we get current project env

@deleteLater deleteLater self-assigned this Jul 11, 2023
@deleteLater deleteLater added the ui label Jul 11, 2023
cosmos-explorer
cosmos-explorer previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@cosmos-explorer cosmos-explorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deleteLater deleteLater marked this pull request as ready for review July 14, 2023 10:51
@cosmos-explorer cosmos-explorer merged commit 37f8b4e into main Jul 14, 2023
1 check passed
@cosmos-explorer cosmos-explorer deleted the refactor/ui-code-clean branch July 14, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmos-explorer cosmos-explorer cosmos-explorer approved these changes

Assignees

@deleteLater deleteLater

Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deleteLater @cosmos-explorer