-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 refactor: change the way we control project and env permissions #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleteLater
reviewed
Jul 15, 2023
modules/front-end/src/app/core/components/header/header.component.ts
Outdated
Show resolved
Hide resolved
modules/front-end/src/app/core/components/header/header.component.ts
Outdated
Show resolved
Hide resolved
modules/front-end/src/app/core/components/project-drawer/project-drawer.component.ts
Outdated
Show resolved
Hide resolved
cosmos-explorer
changed the title
🧹 refactor: IAM project env
🧹 refactored the way to set project and env permissions
Jul 16, 2023
deleteLater
changed the title
🧹 refactored the way to set project and env permissions
🧹 refactor: change the way to control project and env permissions
Jul 16, 2023
deleteLater
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
deleteLater
changed the title
🧹 refactor: change the way to control project and env permissions
🧹 refactor: change the way we control project and env permissions
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes:
Rename ListProjects to CanAccessProject: can be applied to both general and specific projects
- if applied to general projects: can access to all projects
- if applied to a specific project: can access to a specific project
Projects without CanAccessProject action granted won't be displayed in the UI
Remove ListEnvironments: if a user can access a project, he can access to all its envs
except the envs whose CanAccessEnv permission is explicitly denied
Rename AccessEnvs to CanAccessEnv
This PR brings a breaking change, need to update the MongoDb with the following scripts: