馃Ч refactor: let user set redis url directly #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erik247ts
reviewed
Aug 3, 2023
Erik247ts
reviewed
Aug 3, 2023
dsun0720
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify the complete Redis URL directly for da-server service.
Previously, users had to set Redis host, port, and password as separate configuration options. However, this approach was not flexible and didn't allow users to specify SSL options or other advanced configurations easily.
By letting users specify the complete Redis URL, users gain the flexibility to set any Redis configuration options they need, including SSL settings.
Reference