Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 fix variation rollout compare bug #481

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

cosmos-explorer
Copy link
Contributor

@cosmos-explorer cosmos-explorer commented Aug 23, 2023

The FlagComparer would always return UpdateDefaultRuleVariationOrRolloutInstruction if both original and new values are percentage rollouts even they have the same value

@cosmos-explorer cosmos-explorer added bug Something isn't working api labels Aug 23, 2023
Copy link
Contributor

@deleteLater deleteLater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosmos-explorer cosmos-explorer merged commit 6fd8406 into main Aug 23, 2023
1 check passed
@cosmos-explorer cosmos-explorer deleted the fix/semantic-patch-rollout-compare-bug branch August 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants