Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 fix: auditlog parse json error #487

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

cosmos-explorer
Copy link
Contributor

Previously, when creating or deleting a feature flag, we don't generate any instructions, but the change-list component was still initiated which causes an error.
image

The current fix does not instantiate the component if no instructions generated.

@cosmos-explorer cosmos-explorer self-assigned this Sep 4, 2023
@cosmos-explorer cosmos-explorer added bug Something isn't working ui labels Sep 4, 2023
@deleteLater deleteLater changed the title 馃悰fixed auditlog parse json error 馃悰 fix: auditlog parse json error Sep 4, 2023
Copy link
Contributor

@deleteLater deleteLater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deleteLater deleteLater merged commit e175136 into main Sep 4, 2023
1 check passed
@deleteLater deleteLater deleted the fix-auditlog-error branch September 4, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants