Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃Ч refactor: change the way we configure kafka consumer and producer #503

Merged
merged 6 commits into from
Oct 11, 2023
Merged

馃Ч refactor: change the way we configure kafka consumer and producer #503

merged 6 commits into from
Oct 11, 2023

Conversation

deleteLater
Copy link
Contributor

@deleteLater deleteLater commented Oct 9, 2023 •
edited

This PR

  • Split Kafka consumer config and producer config
  • Allow user to specify all Kafka consumer config and producer config

Example environment variables

  • Kafka__Producer__bootstrap.servers
  • Kafka__Consumer__sasl.username
  • Kafka__Consumer__sasl.password
  • Kafka__Consumer__sasl.mechanism
  • Kafka__Consumer__security.protocol

Useful links

@deleteLater deleteLater self-assigned this Oct 9, 2023
@deleteLater deleteLater changed the title 馃Ч refactor: change the way we config kafka consumer and producer 馃Ч refactor: change the way we configure kafka consumer and producer Oct 9, 2023
@deleteLater deleteLater marked this pull request as ready for review October 9, 2023 16:04
@dsun0720 dsun0720 merged commit 061d3de into main Oct 11, 2023
2 checks passed
@dsun0720 dsun0720 deleted the refactor/split-kafka-config branch October 11, 2023 17:30
@deleteLater deleteLater mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsun0720 dsun0720 dsun0720 approved these changes

@cosmos-explorer cosmos-explorer Awaiting requested review from cosmos-explorer

Assignees

@deleteLater deleteLater

Labels
breaking-change infrastructure
Projects
FeatBit
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deleteLater @dsun0720