Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 infra: refactor publish-docker-images.yml #549

Merged
merged 23 commits into from
Nov 30, 2023
Merged

🏗 infra: refactor publish-docker-images.yml #549

merged 23 commits into from
Nov 30, 2023

Conversation

deleteLater
Copy link
Contributor

@deleteLater deleteLater commented Nov 29, 2023 •
edited

This PR

  • Always run publish image GitHub Action manually since we need to decide whether to publish latest image
  • Make publish-docker-image.yml simpler
  • Improving the workflow speed; previously taking 45 minutes, the process now completes in just 22 minutes.

Refer this to check out an example run. Additionally, compare the performance with a previous run (v3.0.0) here.

@deleteLater deleteLater self-assigned this Nov 29, 2023
@deleteLater deleteLater marked this pull request as ready for review November 30, 2023 03:58
cosmos-explorer
cosmos-explorer approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@cosmos-explorer cosmos-explorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deleteLater deleteLater merged commit fbe61a0 into main Nov 30, 2023
4 checks passed
@deleteLater deleteLater deleted the infra/manually-build-and-publish-image branch November 30, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmos-explorer cosmos-explorer cosmos-explorer approved these changes

Assignees

@deleteLater deleteLater

Labels
infrastructure
Projects
FeatBit
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deleteLater @cosmos-explorer