-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start work on player-data loading (#72); default gamemode #96
Start work on player-data loading (#72); default gamemode #96
Conversation
There are no tests yet because I'd like to get some feedback on the NBT-loading/component integration. |
Codecov Report
@@ Coverage Diff @@
## develop #96 +/- ##
===========================================
+ Coverage 54.63% 54.87% +0.23%
===========================================
Files 55 56 +1
Lines 6962 7050 +88
===========================================
+ Hits 3804 3869 +65
- Misses 3158 3181 +23
Continue to review full report at Codecov.
|
server/src/joinhandler.rs
Outdated
let spawn_block_pos = | ||
BlockPosition::new(level.spawn_x, level.spawn_y, level.spawn_z); | ||
let pos = positions.get(player).unwrap(); | ||
let spawn_block_pos = pos.current.block_pos(); | ||
|
||
let spawn_position = SpawnPosition::new(spawn_block_pos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SpawnPosition
packet is used to send the world's spawn position, i.e. the location where a compass would point to. This change should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right. The PlayerPositionAndLookClientbound packet below will need to use different values then.
Thanks! |
Start work on loading player NBT data when it exists.
For the moment, it only loads the gamemode and last save pos, so it does not complete the scope of ticket #72. It should however be the groundwork for loading inventory data.