Start work on player-data loading (#72); default gamemode #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no tests yet because I'd like to get some feedback on the NBT-loading/component integration. |
aramperes
commented
Aug 30, 2019
Codecov Report
@@ Coverage Diff @@
## develop #96 +/- ##
===========================================
+ Coverage 54.63% 54.87% +0.23%
===========================================
Files 55 56 +1
Lines 6962 7050 +88
===========================================
+ Hits 3804 3869 +65
- Misses 3158 3181 +23
Continue to review full report at Codecov.
|
caelunshun
requested changes
Aug 30, 2019
caelunshun
reviewed
Aug 30, 2019
server/src/joinhandler.rs
Outdated
| let spawn_block_pos = | ||
| BlockPosition::new(level.spawn_x, level.spawn_y, level.spawn_z); | ||
| let pos = positions.get(player).unwrap(); | ||
| let spawn_block_pos = pos.current.block_pos(); | ||
|
|
||
| let spawn_position = SpawnPosition::new(spawn_block_pos); |
There was a problem hiding this comment.
The SpawnPosition packet is used to send the world's spawn position, i.e. the location where a compass would point to. This change should be reverted.
There was a problem hiding this comment.
Ah, right. The PlayerPositionAndLookClientbound packet below will need to use different values then.
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start work on loading player NBT data when it exists.
For the moment, it only loads the gamemode and last save pos, so it does not complete the scope of ticket #72. It should however be the groundwork for loading inventory data.