Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon request: Digits #594

Open
curliq opened this issue May 12, 2019 · 19 comments · May be fixed by #649
Open

Icon request: Digits #594

curliq opened this issue May 12, 2019 · 19 comments · May be fixed by #649

Comments

@curliq
Copy link

curliq commented May 12, 2019

Icon Request

@jletey
Copy link

jletey commented Jun 30, 2019

@locness3 @colebemis @curliq How does this look? I made the zero icon have a round zero, but I can change that to a square zero ... depending on what you guys think!

@locness3
Copy link

locness3 commented Jul 1, 2019

@locness3 @colebemis @curliq How does this look? I made the zero icon have a round zero, but I can change that to a square zero ... depending on what you guys think!

Great! Although I think they are quite "squared", but I think we can't do much about this.

@jletey
Copy link

jletey commented Jul 1, 2019

@locness3 That was on purpose ... but yes, I don't think we can do much to change it!

@curliq
Copy link
Author

curliq commented Jul 1, 2019

Was also thinking to have it either with no background so people could decide how to present them, or, to have a square background version and a circle background version.

@jletey
Copy link

jletey commented Jul 1, 2019

@curliq So are you saying get rid of the square surrounding the numbers? I say personally that the icons look to plain without the square!

@curliq
Copy link
Author

curliq commented Jul 1, 2019

Or to add another variation with a circle around them, so people can choose between those two options.

@jletey
Copy link

jletey commented Jul 1, 2019

Or to add another variation with a circle around them, so people can choose between those two options.

@locness3 What do you think?

@locness3
Copy link

locness3 commented Jul 1, 2019

I think that would be great, since we already have circle/rectangle choices for other icons.

@jletey
Copy link

jletey commented Jul 1, 2019

Sounds good @locness3 ... will add digit icons with a circle border!

@jletey
Copy link

jletey commented Jul 1, 2019

Done @locness3 @curliq!

Screen Shot 2019-07-01 at 9 12 37 PM

@locness3
Copy link

locness3 commented Jul 1, 2019

Done @locness3 @curliq!

Screen Shot 2019-07-01 at 9 12 37 PM

That's great, although maybe you should turn the zero into a more "square" shape, to comply with other digits.

@jletey
Copy link

jletey commented Jul 1, 2019

That's great, although maybe you should turn the zero into a more "square" shape, to comply with other digits.

@locness3 Same for the zero in the square icons?

@locness3
Copy link

locness3 commented Jul 1, 2019

That's great, although maybe you should turn the zero into a more "square" shape, to comply with other digits.

@locness3 Same for the zero in the square icons?

yes

@jletey
Copy link

jletey commented Jul 1, 2019

@locness3 done!

Screen Shot 2019-07-01 at 9 25 03 PM

@jletey
Copy link

jletey commented Jul 2, 2019

@locness3 Is it okay to submit a PR?

@locness3
Copy link

locness3 commented Jul 2, 2019

idk really

@jletey
Copy link

jletey commented Jul 2, 2019

idk really

why not @locness3?

@locness3
Copy link

locness3 commented Jul 2, 2019

If you want

@jletey
Copy link

jletey commented Jul 2, 2019

Why not @locness3! Opening a PR now!

jletey added a commit to jletey/feather that referenced this issue Jul 2, 2019
@jletey jletey linked a pull request Jul 2, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants