Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon request: QR Code #598

Open
Aviortheking opened this issue May 14, 2019 · 41 comments · Fixed by lucide-icons/lucide#141
Open

Icon request: QR Code #598

Aviortheking opened this issue May 14, 2019 · 41 comments · Fixed by lucide-icons/lucide#141

Comments

@Aviortheking
Copy link

Icon Request

@Aviortheking Aviortheking changed the title QR Code icon Icon request: QR Code May 14, 2019
@jletey
Copy link

jletey commented Jun 23, 2019

@colebemis @locness3 @Aviortheking How does this look?

@locness3
Copy link

Have tyou made it by yourself ? BTW, please check you are conform with #171 .

@jletey
Copy link

jletey commented Jun 23, 2019

@locness3 I looked at the font-awesome design and then tried to use #171, although I'm not quite sure I did a good job ... but yes, I made it by myself.

@locness3
Copy link

@locness3 I looked at the font-awesome design and then tried to use #171, although I'm not quite sure I did a good job ... but yes, I made it by myself.

Instead of doing what you're doing, use squares with 2px borders.

@jletey
Copy link

jletey commented Jun 23, 2019

@locness3 so no rounded edges ... but 2px borders?

@locness3
Copy link

@locness3 so no rounded edges ... but 2px borders?

You should round edges with a 90degree angles (as states #171

@jletey
Copy link

jletey commented Jun 23, 2019

@locness3 I have updated the icon ... please take a look!

@locness3
Copy link

You should round the bottom-right thing, and make it a compound path.

@locness3
Copy link

locness3 commented Jun 23, 2019

More than just rounding them, you should make them strokes, no fills are allowed.

@jletey
Copy link

jletey commented Jun 23, 2019

@locness3 I have refactored with all of your changes ... unfortunately, it was really hard for me to get the two squares in the bottom-right thing to be apart of the rest of the vector for the bottom-right thing ... hopefully, this isn't a problem!

@locness3
Copy link

@locness3 I have refactored with all of your changes ... unfortunately, it was really hard for me to get the two squares in the bottom-right thing to be apart of the rest of the vector for the bottom-right thing ... hopefully, this isn't a problem!

When you will have rounded the two squares at the bottom right, that will be perfect!

@jletey
Copy link

jletey commented Jun 25, 2019

@locness3 Not exactly quite sure how I'm supposed to round the square, as when I try to round them, they either change to nothing or a ring 😞 ... but, if I change the stroke width to 1px (which is clearly against #171), I get a perfectly rounded square!

@Aviortheking
Copy link
Author

on Figma a single point with stroke isn't shown at all so don't worry about that

@locness3
Copy link

@locness3 Not exactly quite sure how I'm supposed to round the square, as when I try to round them, they either change to nothing or a ring 😞 ... but, if I change the stroke width to 1px (which is clearly against #171), I get a perfectly rounded square!

Do a single path point with a stroke

@jletey
Copy link

jletey commented Jun 25, 2019

@locness3 How exactly do you do a "single path point with a stroke"?

@locness3
Copy link

@locness3 How exactly do you do a "single path point with a stroke"?

Create one path point with your habitual pen tool I guess

@jletey
Copy link

jletey commented Jun 25, 2019

@locness3 Doesn't work ... when I try to do this, by creating a point with the pen tool, it doesn't show up even after I select different strokes

@locness3
Copy link

@locness3 Doesn't work ... when I try to do this, by creating a point with the pen tool, it doesn't show up even after I select different strokes

Have you tried exporting it and oprening in a browser ?

@jletey
Copy link

jletey commented Jun 26, 2019

Have you tried exporting it and oprening in a browser ?

@locness3 Just did ... not showing up

@locness3
Copy link

Have you tried exporting it and oprening in a browser ?

@locness3 Just did ... not showing up

🤔

@reinhart1010
Copy link

I'd like to suggest another design for the QR code icon:
image

This is heavily influenced by several Indonesian digital wallet apps that bear similar icons:
image image image

I decided to use a rounded square on the bottom-right corner to be distinguishable from others, so people may still be able to interpret this as a normal QR code.

You can have a look of the SVG file at https://drive.google.com/open?id=14nO2J2PaODXfcgmB7ZIc3SXf4RPHzXQZ

@locness3
Copy link

Idk, what do you think @johnletey ?

@JelleBlaauw
Copy link

@colebemis @locness3 @Aviortheking How does this look?

You've got the Font-Awesome flag in there, so no, I wouldn't do it like this.

@krrohitch
Copy link

Would like to make a suggestion here - Figma link
image

@locness3
Copy link

@krrohitch To me, this is more "scan qr code" than "qr code".

@krrohitch
Copy link

krrohitch commented Jul 22, 2020

You have a point there. I'll try one without the outer frame.
Meanwhile, this could be used as qr-scan if required.

@krrohitch
Copy link

Made a quick iteration. What do you think @locness3 ?
image

@arjasco
Copy link

arjasco commented Aug 1, 2020

I attempted something similar using the grid icon as the basis.
Screenshot 2020-08-01 at 11 34 51

Would love a native QR code icon that matches the rest of the icon set please!

@johnletey
Copy link

@arjasco Unfortunately, that icon has fills in it - which is against the Feather icon guidelines.

@krrohitch Well done 😍 Would love to see those icons add to @featherity 😉

@arjasco
Copy link

arjasco commented Aug 1, 2020

@johnletey Understood! It wasn't meant to be a candidate for this icon, just a play on an idea before coming to this issue.

How could we see the icon @krrohitch has produced make it in? This repo seems like is really isn't getting much attention which is a shame because it's a great icon set.

Does the mentioned fork contain all the current icons? I'm currently creating an SVG map with a subset of the icons I require, annoyingly could really do with a QR code one ☹️

@johnletey
Copy link

@arjasco Understand 😄

And yes, the fork is actively maintained by myself and the contributors. @ericfennis is working hard on publishing usable packages! (lucide-icons/lucide#52)

@arjasco
Copy link

arjasco commented Aug 1, 2020

@johnletey Looks great! Will keep an eye on the improvements and might look to swapping to this. Thanks!

@CodeLake
Copy link

Been wanting to use the native feather QR-Code icon for a while and ending up using a work-around. Has the completed icon been published?

@reinhart1010
Copy link

Yeah, one has been merged to a fork of Feather icons - see lucide-icons/lucide#141

@CodeLake
Copy link

Yeah, one has been merged to a fork of Feather icons - see lucide-icons/lucide#141

Thank you. I was wondering if there is a plan to add it to feather icon set natively?

@lauhon
Copy link

lauhon commented Apr 19, 2023

Bump, i would love this :)

@locness3
Copy link

This icon is available in @lucide-icons, a community fork of Feather : https://lucide.dev/icon/qr-code?search=qr

@lauhon
Copy link

lauhon commented Apr 21, 2023

Thanks for the information! :)

But wouldn't it be nice to merge it to the main repo?

For example, my usecase is to use the icons via React Native Feather which - as far as I know - only has access to the main icons and has no built in api to configure it to use the community fork.

Im curious, whats the "right" way to go about this, should I make an effort to combine React Native Feather with the community icons, or should @feathericons include more community icons?

@karsa-mistmere
Copy link

Lucide also has a standalone package for React Native, and has a whopping 975 icons compared to Feather's 287, I would advise you to just switch over to lucide-react-native from react-native-feather.

@lauhon
Copy link

lauhon commented Apr 21, 2023

Oh, nice. Thanks for pointing that out.

Almost makes me feel like a traitor, but in that case I'm gonna switch to lucide icons :D

@locness3
Copy link

But wouldn't it be nice to merge it to the main repo?

Yes it would be. But the repository has no active maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.