feat: Add `google` icon #114

fauxparse · 2017-06-14T22:33:42Z

Add a Google icon for login using Google OAuth.

wappsdotgr · 2017-06-15T15:11:19Z

@colebemis Since you included this google icon you can close mine in #93 or use it with a '+' for google plus

tjkns94 · 2018-03-24T02:53:45Z

hi, what is the hold up here?

adaniello · 2019-03-21T09:34:55Z

No way to merge this?

locness3 · 2019-03-21T16:33:32Z

@colebemis Since you included this google icon you can close mine in #93 or use it with a '+' for google plus

Google plus is closing

locness3 · 2019-03-21T16:33:52Z

No way to merge this?

@colebemis have to review first

colebemis · 2019-03-21T17:41:00Z

I'll take a look at this today 👍 Sorry for the delay 😅

colebemis · 2019-03-21T17:46:23Z

@fauxparse It looks like this icon is located in a icons/logos directory. Could you move into the icons directory?

colebemis · 2019-03-21T17:50:04Z

icons/logos/google.svg

@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="#000" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
+  <path d="M21.8,10h-2.6l0,0H12v4h5.7c-0.8,2.3-3,4-5.7,4c-3.3,0-6-2.7-6-6s2.7-6,6-6c1.7,0,3.2,0.7,4.2,1.8l2.8-2.8C17.3,3.1,14.8,2,12,2C6.5,2,2,6.5,2,12s4.5,10,10,10s10-4.5,10-10C22,11.3,21.9,10.6,21.8,10z"/>
+</svg>


It looks like the formatting of this SVG file is slightly different than the rest of the files. Could you run npm run build to fix it? There are instructions on how to do that at the bottom of this comment: #171 (comment)

fauxparse · 2019-03-21T22:53:57Z

@fauxparse It looks like this icon is located in a icons/logos directory. Could you move into the icons directory?

Done. I guess the logos directory existed when I made the pull request back in August... ;)

fauxparse · 2019-03-21T22:54:16Z

@colebemis Should be good to go now.

codecov · 2019-03-21T22:55:45Z

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #114   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d42ac8...1ccdf79. Read the comment docs.

jletey · 2019-04-19T11:03:05Z

What's the hold up on this?

mxstbr · 2019-05-08T06:46:48Z

Would love to have this!

tbouron · 2019-07-07T06:00:21Z

Hey there, any reason this hasn't be merged yet? I too would love to have the Google logo for my Google AOuth button rather than relying on some PNG icon.

locness3 · 2019-07-07T08:13:59Z

Hey there, any reason this hasn't be merged yet?

Waiting for @colebemis ...

mittalyashu · 2019-07-22T06:07:06Z

There should be a minimum of 2px of spacing

simonschaufi · 2019-08-19T22:56:47Z

If I adjust the font awesome google icon (https://fontawesome.com/icons/google?style=brands) to have just the line, then it looks like this:

@fauxparse Could you adjust it to look similar like that?

fauxparse · 2019-08-20T00:33:21Z

@fauxparse Could you adjust it to look similar like that?

This PR is over two years old, I'm really not sure I need to.

NickeManarin · 2020-02-03T12:57:40Z

@colebemis Could you take a look at this? This PR is quite old...

omnibrain · 2020-02-22T16:41:06Z

@colebemis please? Looks like all it needs at this point is one last approval. I think a lot of people are waiting for this

locness3 · 2020-02-23T08:08:24Z

Sadly it looks like @colebemis doesn't want to merge new icons...

omnibrain · 2020-02-23T11:26:45Z

@colebemis I'll send you $5 in bitcoins if you just click that merge button. Please, oh please mighty maintainer, let us have this. We do not ask for much. We are but some humble developers, trying to make a living, barely getting by, craving that beautiful G. We never questioned your authority, never even as much as glanced at the new font-awesome icons. Have mercy with us, o mighty maintainer.

locness3 · 2020-02-24T15:09:18Z

@omnibrain not sure that's how things work. And what prevents you from downloading the svg from @fauxparse's fork or using his whole repo?

omnibrain · 2020-02-24T16:51:34Z

@locness3 using the official package is obviously nicer than using some fork but I guess that‘s what I‘ll do. I think what bothers me is that I don‘t see any reason for this not to be merged? Has feather icons reached the end of development? I‘m OK with any explanation, but no explanation at all is hard to accept.

locness3 · 2020-03-01T12:17:06Z

@omnibrain Brand icons are deprecated in feather, read #763, tho it would be cool to merge the current brand icons requests and only reject further ones.
But more generally @colebemis doesn't give any sign of life concerning this project.

NickeManarin · 2020-03-01T16:47:15Z

@omnibrain Brand icons are deprecated in feather

That's a harsh decision. Deprecating all brand icons instead of accepting the ones that are simple enough?
That's like deprecating all icons because most are too complex and complicated to be drawn in a 24x24px grid.

locness3 · 2020-03-08T16:52:18Z

The problem, i guess, is brand icons are unique, and not adaptable to any icon set.

And if all you need are brand icons SVGs, simpleicons.com dors the job.

simonschaufi · 2020-07-17T19:54:00Z

Everyone who wants to manually add the icon, here is the path from simpleicons a little bit adjusted:

<symbol id="google" viewBox="0 0 24 24">
    <path d="M12.219 10.43 12.219 14.199 18.457 14.199C18.207 15.816 16.574 18.941 12.219 18.941 8.465 18.941 5.402 15.836 5.402 12 5.402 8.164 8.469 5.059 12.219 5.059 14.355 5.059 15.785 5.965 16.605 6.754L19.59 3.875C17.672 2.086 15.188 1 12.219 1 6.137 1 1.219 5.918 1.219 12 1.219 18.082 6.137 23 12.219 23 18.57 23 22.781 18.535 22.781 12.25 22.781 11.527 22.703 10.977 22.605 10.43ZM12.219 10.43"/>
</symbol>

emmahsax · 2020-07-29T16:08:54Z

I'll echo @fauxparse @omnibrain and say that this would be soooo helpful!

@colebemis Please? 🙏🏼

PeterShaggyNoble · 2020-07-29T16:19:05Z

As per #763, brand icons have been deprecated here in favour of Simple Icons, where this is already available: https://simpleicons.org/?q=Google

emmahsax · 2020-07-29T19:22:45Z

Ah yes, I saw that. I wasn't sure if that was the final decision yet or not. I found this substitution too, which sort of looks in the style of feather.

gianfrancolombardo

Looks perfect

vonec · 2021-03-05T09:32:05Z

when will this get merged ?

locness3 · 2021-03-07T08:11:25Z

Never #763

dev-ea previously approved these changes Aug 1, 2018

View reviewed changes

martinsvoboda previously approved these changes Aug 26, 2018

View reviewed changes

colebemis reviewed Mar 21, 2019

View reviewed changes

fauxparse dismissed stale reviews from martinsvoboda and dev-ea via 36a4a64 March 21, 2019 22:53

fauxparse force-pushed the master branch from 08840cd to 36a4a64 Compare March 21, 2019 22:53

feat: Add google icon

1ccdf79

fauxparse force-pushed the master branch from 36a4a64 to 1ccdf79 Compare March 21, 2019 22:56

locness3 mentioned this pull request Aug 26, 2019

Icon request: google #93

Open

omnibrain approved these changes Feb 22, 2020

View reviewed changes

johnletey mentioned this pull request Sep 3, 2020

Icon Request : Google, Linkedin #967

Open

gaffy94 approved these changes Sep 8, 2020

View reviewed changes

gianfrancolombardo approved these changes Dec 10, 2020

View reviewed changes

fauxparse closed this Mar 7, 2021

feat: Add google icon #114

feat: Add google icon #114

Conversation

fauxparse commented Jun 14, 2017

wappsdotgr commented Jun 15, 2017 • edited Loading

tjkns94 commented Mar 24, 2018

adaniello commented Mar 21, 2019

locness3 commented Mar 21, 2019

locness3 commented Mar 21, 2019

colebemis commented Mar 21, 2019 • edited Loading

colebemis commented Mar 21, 2019

colebemis Mar 21, 2019

Choose a reason for hiding this comment

fauxparse Mar 21, 2019

Choose a reason for hiding this comment

fauxparse commented Mar 21, 2019

fauxparse commented Mar 21, 2019

codecov bot commented Mar 21, 2019 • edited Loading

Codecov Report

jletey commented Apr 19, 2019

mxstbr commented May 8, 2019

tbouron commented Jul 7, 2019

locness3 commented Jul 7, 2019

mittalyashu commented Jul 22, 2019

simonschaufi commented Aug 19, 2019 • edited Loading

fauxparse commented Aug 20, 2019

NickeManarin commented Feb 3, 2020

omnibrain commented Feb 22, 2020

locness3 commented Feb 23, 2020

omnibrain commented Feb 23, 2020

locness3 commented Feb 24, 2020

omnibrain commented Feb 24, 2020

locness3 commented Mar 1, 2020

NickeManarin commented Mar 1, 2020 • edited Loading

locness3 commented Mar 8, 2020

simonschaufi commented Jul 17, 2020 • edited Loading

emmahsax commented Jul 29, 2020

PeterShaggyNoble commented Jul 29, 2020

emmahsax commented Jul 29, 2020

gianfrancolombardo left a comment

Choose a reason for hiding this comment

vonec commented Mar 5, 2021

locness3 commented Mar 7, 2021

feat: Add `google` icon #114

feat: Add `google` icon #114

wappsdotgr commented Jun 15, 2017 •

edited

Loading

colebemis commented Mar 21, 2019 •

edited

Loading

codecov bot commented Mar 21, 2019 •

edited

Loading

simonschaufi commented Aug 19, 2019 •

edited

Loading

NickeManarin commented Mar 1, 2020 •

edited

Loading

simonschaufi commented Jul 17, 2020 •

edited

Loading