Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Todo] Persist inputs to localStorage and fix color input #551

Open
anthonygedeon opened this issue Jun 19, 2020 · 3 comments
Open

[Todo] Persist inputs to localStorage and fix color input #551

anthonygedeon opened this issue Jun 19, 2020 · 3 comments

Comments

@anthonygedeon
Copy link

When playing with the customize tools, I noticed that the reset button is not really noticeable after changing the properties of the icons.

Styling the reset button to red will signify danger and become noticeable.

Here's a screenshot of what I am talking about

image

CSS Code

.css-s700uk {
   --background-color: hsl(358, 91%, 45%); /* pick a suitable red color */
    box-shadow: inset 0 0 0 1px var(--background-color);
    background-color: var(--background-color);
}
@johnletey
Copy link

As far as a suitable red colour goes, this site uses Primer Colours:

@zaydek
Copy link
Collaborator

zaydek commented Aug 22, 2020

Thanks for opening this issue!

I’m going to refresh the site soon, and I’ll make sure to attend to low-contrast ratio problems like this one. I totally see the problem as you outlined here, @anthonygedeon. 👍

@zaydek zaydek changed the title Reset button styling [Todo] Persist inputs to localStorage and fix color input Aug 22, 2020
@zaydek
Copy link
Collaborator

zaydek commented Aug 22, 2020

#292 appears to be related, so these should likely be tackled at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants