[security issue] fix populate injecting provider into source schema argument #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Populate hook is modifying original
options
argument in place causing provider field being injected into all subsequent populate calls.If the first populate call has been done with
provider = undefined
(for instance by restrictToOwner hook), populate inject this provider into originaloptions
. The second call from rest provider is performed withprovider = undefined
because that value was injected intooptions
in previous popolate call.Such behavior is a severe security issue making possible to fetch related objects bypassing owner check.
More detailed description is given here:
https://bitbucket.org/AntaraSI/feathers-populate-test