Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

You should create new connection strings via "generate service" #32

Closed
eddyystop opened this issue Sep 2, 2018 · 4 comments
Closed

Comments

@eddyystop
Copy link
Member

eddyystop commented Sep 2, 2018

The normal way to create a connection is to create a service using that connection with `generate service". You will be prompted for the connection params after the service params.

If you create a connection first, say for Sequelize and MySQL, and then create the first service to use it, the sequelize.js module will not be created. You need to either run generate all or rerun generate service for the same service. The generated code correct after this.

Fixing this is a chicken-or-the-egg issue. Its not a critical issue, and we will address it at some later time.

@eddyystop eddyystop changed the title You need to create new connection strings via "generate service" You should create new connection strings via "generate service" Sep 2, 2018
@bravo-kernel
Copy link
Contributor

bravo-kernel commented Sep 3, 2018

Right, this order does NOT create src/sequelize.js:

feathers-plus generate app
npm install sequelize mysql2 feathers-sequelize --save
feathers-plus generate options
feathers-plus generate connection
feathers-plus generate service

This order DOES generate every needed file:

feathers-plus generate app
npm install sequelize mysql2 feathers-sequelize --save
feathers-plus generate options
feathers-plus generate service

@eddyystop
Copy link
Member Author

Fix published in f+/cli v0.7.8 using generator v0.6.7.

@bravo-kernel
Copy link
Contributor

Just tested successfully. Thanks for the solid fix 👏

@eddyystop
Copy link
Member Author

Thanks for the confirmation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants