Add support for dot notation, fix some whitespace #8
Conversation
| @@ -95,32 +97,47 @@ describe('Verifier', () => { | |||
| expect(result).to.deep.equal(user); | |||
| }); | |||
| }); | |||
|
|
|||
| it('allows dot notation for password field', () => { | |||
| const oldPasswordField = verifier.options.passwordField; | |||
There was a problem hiding this comment.
I just realized that we don't need to store and reset oldPasswordField since everything will be reset before every test.
| $limit: 1 | ||
| }; | ||
|
|
||
| // set usernameField in query, accepting dot notation | ||
| set(query, this.options.usernameField, username); |
There was a problem hiding this comment.
I'm wondering what the default query for nested properties should be since it depends on the database. E.g. Mongodb uses the actual dot separated string { query: { 'username.field': 'test' } } instead of a nested object.
Not sure how SQL databases (Sequelize, Knex) do do it and some (Memory, LocalStorage) do not support nested at all. I think the safest bet might be to use the original way of setting it ([this.options.usernameField]: username) so it works at least with MongoDB (and for everything else you have to write your own verifier). Thoughts?
There was a problem hiding this comment.
Hm, I see. I have no issue with writing custom verifier for applications; that makes sense because every application has different needs and requirements.
I was originally thinking that the user would use dot notation for usernameField if he knew his database supported it, and if he knows it doesn't support dot notation he would just write the root field.
That still doesn't solve the problem of MongoDB not using nested objects.
And then of course there's the error handling (letting the user know that the usernameField he specified is incorrect for his specific database, as opposed to no user being found) which could get messy pretty quickly.
So a custom verifier sounds like the way to go.
I'm not sure if this is being done yet, but maybe in the future we could attach some data to the service that specifies which type of database driver the user has attached to the service. That would allow us to perform different operations inside of feathers packages based on those values.
|
This is great! Two comments and once we figure those out we can get it in. |
Storing the password and resetting the object wasn't needed because Mocha gives us a clean slate for every test it performs
Lots of edge-cases that weren't being handled with this implementation. Better to remove these changes for now and come back to this later. For now, if you need dot notation for your usernameField you're better off writing a custom verifier function.
|
Released as |
This PR adds support for dot notation in both the
usernameFieldandpasswordField.Solves #7