This repository has been archived by the owner on Sep 11, 2018. It is now read-only.
Fix for Update an existing entity in verifier #18 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
reviewed
Aug 21, 2018
lib/index.js
Outdated
| @@ -73,6 +87,7 @@ function init (options = {}) { | |||
| app.get(oauth2Settings.path, auth.express.authenticate(name, oauth2Settings)); | |||
| app.get( | |||
There was a problem hiding this comment.
Would it be safe to just add the cookieParser middleware here?
There was a problem hiding this comment.
Yes it would, however, social linking would not work if cookies aren't enabled by the developer for @feathersjs/authentication-jwt.
There was a problem hiding this comment.
I think that should be fine, since you need to do that when using the client with oAuth2 anyway (the generator enables cookies automatically in that case already).
|
Actually just realized that this will work through feathersjs-ecosystem/authentication-jwt#55 if cookies are enabled, no cookie parser necessary. Thank you again, this is great work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner fix for issue #18 and does not require changes to any existing code. The user will, however, have to enable cookies for social linking to work and add
cookie-parser