Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

app.get('auth') vs app.get('authentication') #497

Closed
brenmcnamara opened this issue May 6, 2017 · 2 comments
Closed

app.get('auth') vs app.get('authentication') #497

brenmcnamara opened this issue May 6, 2017 · 2 comments

Comments

@brenmcnamara
Copy link

brenmcnamara commented May 6, 2017

Maybe I'm not understanding the code, but it seems that app.get(<something>) fetches from the relevant config file in the /config directory.

In the documentation here, it suggests the name of this config should be 'auth' for the authentication config. In addition, the code in feathers-authentication-local and feathers-authentication-jwt make the assumption that their configs can be fetched using app.get('auth'). However, when using the generator to generate the authentication service:

feathers generate authentication

The config file is modified to have an "authentication" config, not "auth". Is this correct?

@marshallswain
Copy link
Member

I believe the modules default location needs to be updated.

@ekryski
Copy link
Member

ekryski commented May 10, 2017

Yes this was changed in the generator but was never updated in the auth modules. I think because the generator is set up to pass the auth configs explicitly this wasn't caught sooner. I have PRs coming.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants