Update Library Dependencies and Code for Feathers 5 (Dove) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade feathers to dove * Add typings related for dove migration * First iteration on tests, need more work * Update dependencies to pre.30 * Transform hooks in a generic way for HookContext * Add @sinclair/typebox in dev dependency (need to be removed later) * Set node >= 14 for github CI and package.json as feathers dove supports node >= 14 * Fix tests and implementation * use NullableId for checkUnique * update hashPassword for reusing same context instead of new one (never transmitted) * replace typing for hooks as @fratzinger advice * Update to dove pre.31
✅ Deploy Preview for feathers-a-m ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pdfowler
changed the title
pdfowler
changed the title
pdfowler
changed the title
|
Anyone to review this PR? |
|
As far as I can see I don't see any breaking changes or doubtful refactoring and tests are passing, good job. However, as I am less familiar with latest typescript version I suggest @fratzinger to review it as well. |
claustres
approved these changes
Sep 20, 2023
fratzinger
approved these changes
Sep 20, 2023
|
I'll merge and do some chore work like updating dependencies right now. I'll release a major version afterwards. Thank you all for your work and sorry for the delay! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm putting the final touches on our upgrade to Feathers v5 Dove, and keep running into inconsistent builds, with probelms traced back to v4.x feathers-common and feathers-adapter-commons libraries getting referenced from this library. This PR brings feathers-authentication-management in-line with the v5 release.
This PR builds on the branch from @mdartic and ensures that the test suite is passing. I am currently testing an internaly published package based on this branch and will update as needed.
Todo
Other Information