Patch bulk multi support #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
havent added tests for it yet. let me know if you like the idea and then i'll add. tnx |
|
@daffl what do you think of this? We had to fork the repo to add this or our app could not use this plugin at scale. Adding this feature makes bulk writes possible which allows for much better efficiency indexing to ES. |
|
LGTM, thought @jciolek might chime in but I can release it with some tests added and the necessary documentation updates. |
|
cool I'll try to add tests and docs in the next few days.
thanks!
…On Wed, Jun 26, 2019 at 6:33 PM David Luecke ***@***.***> wrote:
LGTM, thought @jciolek <https://github.com/jciolek> might chime in but I
can release it with some tests added and the necessary documentation
updates.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#85?email_source=notifications&email_token=AK76OY7O6ZO6LJNR2SVEMR3P4OD23A5CNFSM4HNEDUB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYT5QVI#issuecomment-505927765>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK76OY2F7NTP6UJ4Q6QUWA3P4OD23ANCNFSM4HNEDUBQ>
.
|
|
Hey @orgalaf, thanks for contributing! I've noticed that the tests are failing: https://travis-ci.org/feathersjs-ecosystem/feathers-elasticsearch/builds/551348861 No idea why it's not showing in the PR. Could you rebase against master and see what happens then? |
|
Sure thing. I'll try to get to it asap. Thanks for the heads up!
…On Fri, Jun 28, 2019 at 2:56 AM Jacek Ciolek ***@***.***> wrote:
Hey @orgalaf <https://github.com/orgalaf>, thanks for contributing!
I've noticed that the tests are failing:
https://travis-ci.org/feathersjs-ecosystem/feathers-elasticsearch/builds/551348861
No idea why it's not showing in the PR. Could you rebase against master
and see what happens then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#85?email_source=notifications&email_token=AK76OY4ATHVA5C3OLGAWGITP4VHSDA5CNFSM4HNEDUB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYVZHQ#issuecomment-506551454>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK76OY4ET4WXWBCZLP6GUXTP4VHSDANCNFSM4HNEDUBQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for patching multiple docs in batches by sending an array of docs in the data. If data sent to patch is an array, patch-bulk will build a batch update that updates each doc separately rather than finding all docs that match a criteria and updating all of them with the same changes.