Localstorage working #1
Conversation
| @@ -19,19 +19,27 @@ class LocalStorage extends Service { | |||
| } | |||
|
|
|||
| create(... args) { | |||
| return super.create(... args).then(this.flush); | |||
| return super.create(... args).then(data => { | |||
| return this.flush.call(this, data); | |||
There was a problem hiding this comment.
Shorthand: return super.create(... args).then(data => this.flush(data));
There was a problem hiding this comment.
I'm pretty sure I tried that and it didn't work. I'll double check.
| ready() { | ||
| if(!this.store) { | ||
| return Promise.resolve(this.storage.getItem(this.storageKey)) | ||
| .then(str =>JSON.parse(str || '{}')) |
There was a problem hiding this comment.
I think we might have to have a try catch here in case someone pre-loads their localstorage data with invalid JSON.
daffl
force-pushed
the
localstorage-working
branch
from
a5b7246
to
605e911
Compare
|
feathersjs-ecosystem/errors#26 will need to be landed and |
|
Good thing is that |
|
Still need to get a new version of |
This gets all the tests passing (server side) and adds examples, etc. In theory because the node module api is the same as the browser it should work just fine there too.