Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update '_remove' method #364

Merged
merged 2 commits into from Jan 8, 2020
Merged

update '_remove' method #364

merged 2 commits into from Jan 8, 2020

Conversation

sarkistlt
Copy link
Contributor

#361

Summary

Better support for shard cluster.

Other Information

Replace findOneAndDelete with combination of findById and deleteOne, because in the shard cluster based on MongoDB specification if you are using findOneAnd[*] you have to pass entire shard key, which can be a combination of different fields.

This should not be required when you trying to remove document from the collection, just providing _id should be enough.

@sarkistlt
update '_remove' method
7d9edeb 
#365 better support for shard cluster
@marshallswain
Copy link
Member

marshallswain commented Jan 4, 2020 •
edited

@sarkistlt thanks for the PR. I've just merged another PR that fixes a similar issue for patch requests. Can you address the 32 failing tests? Please let me know.

@sarkistlt
remove method
dd5895e 
fix for failed test that uses id + query to remove record(s)
@sarkistlt
Copy link
Contributor Author

@marshallswain ok should be fine now

@marshallswain marshallswain merged commit 5fbe560 into feathersjs-ecosystem:master Jan 8, 2020
@marshallswain marshallswain mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sarkistlt @marshallswain