Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mergeAllowEager #14

Closed
chrisronline opened this issue Apr 23, 2018 · 2 comments
Closed

Support for mergeAllowEager #14

chrisronline opened this issue Apr 23, 2018 · 2 comments

Comments

@chrisronline
Copy link

Hi,

I've been using this for the past couple weeks and it's been working great, but I was wondering if this library supports mergeAllowEager? I didn't see it anywhere in the docs and I didn't see anything in the source code, but just wanted to check.

Thanks

@mcchrish
Copy link
Member

mcchrish commented Jul 8, 2018

@chrisronline sorry for a very late response. Currently it's not supported. It does looks nice as an API where we allow arrays in eager queries instead of just a string.

I don't have much time to look into it, but contributions are always welcome 👍

@dekelev
Copy link
Member

dekelev commented Oct 12, 2018

@chrisronline v1.2.0 added support for mergeAllowEager.

Pass params.mergeAllowEager to dynamically merge the given expression with the service's allowEager expression for each service call.

It allows to maintain a base allowEager list for a service and to extend it in the service hooks using some logic, like the user permission role.

@dekelev dekelev closed this as completed Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants