Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types not found #56

Closed
jakobrosenberg opened this issue Aug 31, 2019 · 4 comments
Closed

Typescript types not found #56

jakobrosenberg opened this issue Aug 31, 2019 · 4 comments

Comments

@jakobrosenberg
Copy link

jakobrosenberg commented Aug 31, 2019

Just rolled a Feathers app with Typescript and Objection. After npm run dev I get the following error:

Could not find a declaration file for module 'feathers-objection'.

Additionally I get the error Cannot find name 'Application' in the autogenerated user.class.ts

EDIT
Unlike feathers-knex, there's no types folder in node_modules/feathers-objection

@deniskk12
Copy link

@jakobrosenberg Hi, did you find any solution? Have the same issue.

@vonagam
Copy link
Contributor

vonagam commented Sep 4, 2019

There is pending PR #48 which should fix it.

@deniskk12
Copy link

Typescript declarations issue is resolved, but errors are still here:

src/services/users/users.class.ts(8,47): error TS2304: Cannot find name 'Application'.

src/services/users/users.class.ts(13,7): error TS2345: Argument of type '{ model: any; idSeparator?: string | undefined; jsonSchema?: any; allowedEager?: string | undefined; namedEagerFilters?: any; eagerFilters?: any; allowedInsert?: any; insertGraphOptions?: any; ... 8 more ...; filters?: string[] | undefined; }' is not assignable to parameter of type 'Partial<ObjectionServiceOptions>'. Object literal may only specify known properties, but 'model' does not exist in type 'Partial<ObjectionServiceOptions>'. Did you mean to write 'Model'?

@vonagam vonagam mentioned this issue Sep 5, 2019
@daffl
Copy link
Member

daffl commented Sep 6, 2019

Fixed in v4.2.3

@daffl daffl closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants