Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies in ecosystem packages #75

Closed
vonagam opened this issue Dec 17, 2019 · 1 comment
Closed

Dependencies in ecosystem packages #75

vonagam opened this issue Dec 17, 2019 · 1 comment

Comments

@vonagam
Copy link
Contributor

vonagam commented Dec 17, 2019

objection is required in sources and in types of feathers-objection, yet objection is listed only in devDependencies.

Other ecosystem packages with similar situations:

mongoose: not used in sources but mongoose is in peerDependencies, types on the other hand are used but @types/mongoose is only in devDependencies.

mongodb: used in sources and in types, both mongodb and @types/mongodb are listed only in devDependencies.

knex: used in types, knex is only in devDependencies.

elasticsearch: used in types, @types/elasticsearch is only in devDependencies.

nedb: used in types, @types/nedb is only in devDependencies.

@dekelev
Copy link
Member

dekelev commented Dec 27, 2019

Thanks @vonagam, Added objection v1.x as peer-dependency in feathers-objection v4.6.4

@dekelev dekelev closed this as completed Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants