Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Objection v3 and deprecation of eager and joinEager #77

Closed
tmartensen opened this issue Dec 27, 2019 · 1 comment
Closed

Comments

@tmartensen
Copy link

I was looking at the documentation for $eager and $joinEager, and while viewing the Objection reference material, I see that the related eager() and joinEager() methods will be deprecated in Objection v3 in favor of withGraphFetched and withGraphJoined. Are there plans to change this API to reflect those deprecations, or will it be OK to continue using $eager and $joinEager?

@dekelev
Copy link
Member

dekelev commented Dec 27, 2019

It's OK to keep using $eager, $joinEager & $joinRelation and they should still work fine with Objection v2.x, though you'll get deprecation warnings. I do recommend using Objection v1.6.11 until full support is added to feathers-objection, which I plan to do soon.

@dekelev dekelev closed this as completed Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants