Patch multi throws NotFound error if new data doesn't match original query

[robbyphillips]

I wrote a test case that uses this library's testing infrastructure. Should be able to just add it to the testing directory.

import { expect } from 'chai';
import feathers from '@feathersjs/feathers';
import knex from 'knex';
import service from '../src';
import People from './people';
import { Model } from 'objection';

const db = knex({
  client: 'sqlite3',
  debug: false,
  connection: {
    filename: './db.sqlite'
  },
  useNullAsDefault: false
});

// Bind Objection.js
Model.knex(db);

const app = feathers().use(
  '/people',
  service({
    model: People,
    id: 'id',
    multi: ['create', 'patch'],
    whitelist: ['$and', '$like', '$between', '$notBetween'],
    events: ['testing']
  })
);

const people = app.service('people');

function clean (done) {
  db.schema.dropTableIfExists('people').then(() => {
    return db.schema
      .createTable('people', (table) => {
        table.increments('id');
        table.string('name');
        table.integer('age');
        table.integer('time');
        table.boolean('created');
      })
      .then(() => done());
  });
}

describe('Additional Patch Test', () => {
  before(clean);
  after(clean);

  beforeEach(async () => {
    await people.create([
      {
        id: 1,
        name: 'Ahmed',
        age: 35
      },
      {
        id: 2,
        name: 'Hans'
      },
      {
        id: 3,
        name: 'Samantha'
      }
    ]);
  });

  afterEach(async () => {
    try {
      await people.remove(1);
    } catch (err) {}
    try {
      await people.remove(2);
    } catch (err) {}
    try {
      await people.remove(3);
    } catch (err) {}
  });

  it('patch with null id and query', () => {
    return people
      .patch(
        null,
        { age: 42 },
        {
          query: {
            age: null
          }
        }
      )
      .then((data) => {
        expect(data.length).to.be.equal(2);
      });
  });
});

Expected

We should be able to patch multiple items and get back the changed items, even if the data changed is in the original query.

What happens?

If the data used to find the items in the original query changes, the patch operation succeeds in changing the items in the database, but then fails and throws a NotFound: No record found of id 'null error, rather than returning the data.

This is breaking functionality like "soft delete" for me.

[dekelev]

Hi @robbyphillips , I've added the $noSelect query operator to be used also for use-cases like yours. Check it out.

[robbyphillips]

Is this the expected behavior, though? All other patch operations return the modified data.

[dekelev]

It is an expected behavior in the sense that it has always behaved this way, but the behavior could not align with the expected behavior from FeathersJS database adapters.

I'll keep the ticket opened until I can verify this.

[dekelev]

Thanks @robbyphillips, v5.4.0 was released.

Patch with same field in data & query now returns success result.