Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Challenges with watching changefeeds and hooks #76

Closed
daffl opened this issue Mar 25, 2017 · 2 comments
Closed

Challenges with watching changefeeds and hooks #76

daffl opened this issue Mar 25, 2017 · 2 comments
Labels

Comments

@daffl
Copy link
Member

daffl commented Mar 25, 2017

#75 introduced somewhat of a fix for the following problem:

When watching RethinkDB changefeeds we were just sending the data we get from the database directly as a real-time event. Unlike a normal method call, this means that the data did not get processed through hooks (specifically after) hooks. The current solution is to run the data manually through the respective methods after hooks.

Potential problems are that there is no way to get the information what original method call caused the change (or if it was a Feathers method call at all). This means that hook.params will be empty (no params.user, params.provider, params.query etc.).

Currently hook.params will be set to { query: {} }

I don't think this is really a fixable issue but will put it here for visibility and probably add that caveat to the docs.

@daffl
Copy link
Member Author

daffl commented Mar 29, 2017

Due to these limitations I'm thinking that for the final release (v1.0) watching changefeeds should be disabled by default pointing out these caveats.

@daffl
Copy link
Member Author

daffl commented Jul 19, 2019

Closing, see #119

@daffl daffl closed this as completed Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant