This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Allow changefeed event data to be processed by after hooks
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
changed the title
after hook dataafter hooks
|
Makes sense. |
|
Is it possible to disable this? It's breaking my production system because I rely on things set in before hooks. |
|
I can add a flag. For now just stick with v0.3.x since this is the only thing that changed in (the version incompatible) 0.4. |
|
I added a |
maksnester
reviewed
Apr 6, 2017
| runHooks('remove', data.old_val) | ||
| .then(hook => this.emit('removed', hook.result)); | ||
| } else { | ||
| runHooks('patch', data.new_val).then(hook => { |
There was a problem hiding this comment.
How do you know which hooks, for patch or for update should be used here?
It seems like 'update' hooks won't be called.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real-time events are not being sent with the final data if you modify them in an
afterhook. The problem is that we are sending the plain changefeed data instead of the data processed through hooks in a normal method call. The current solution is to run theafterhook chain for the given method manually.