Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config contains idType to set default for application #108

Merged
merged 1 commit into from
May 29, 2018

Conversation

andys8
Copy link
Contributor

@andys8 andys8 commented May 29, 2018

Summary

It is possible to define idType (by default "integer") per service. This PR adds an optional param idType to the root configuration object. The value is the default but can be overwritten.

  • The changes are backwards compatible.
  • I added the param to the test. I'm not really proud of the way it is, but there is a test. A test setup with multiple instances would be an option in the future, but adds complexity (failed shutdowns, timing, ports).

@daffl daffl merged commit 9e4e9fc into feathersjs-ecosystem:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants