chore: Standardise concatenation and object keys #131
Merged
+67
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
approved these changes
Feb 16, 2019
There was a problem hiding this comment.
Looks good. I wonder why it didn't get caught by the linter. I think the semistandard command in https://github.com/feathersjs-ecosystem/feathers-swagger/blob/master/package.json#L34 should be semistandard lib/**/*.js test/**/*.js examples/**/*.js --fix
Standardise some basic formatting: - string concatenation uses backticks - strings with double quotes have been replaced with single quotes - object keys only have quotes where reqired - default response codes are ordered numerically
EspadaV8
force-pushed
the
chore/standardise-code
branch
from
54dfd42
to
c25213b
Compare
|
Running the linter fixed the quote marks but none of the other changes. Are things like object key names and concatenation part of semistandard? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardise some basic formatting: