-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor lib to add support for OpenAPI v3 #140
Conversation
…able, prepare split of openapi v2 and v3, create structure for multiple examples
…QueryParameters option
…example, update readme for feathers v3
@daffl Well this one got big. I hope this is no problem because you said a rewrite would be the best approach. I added the changed stuff to the changelog. As I see you are using automated changelog generation, should I remove that and create one issue or multiple issues for every line that is not connected to a issue already? Things I did not in this branch but that should be done:
|
This is great, thank you! I'll hopefully get to do a review next week. As for your questions
Thanks again for doing this! |
The used dependency is swagger-ui-dist, which is used whenever the uiIndex option is not false. But swagger-ui is not used. As swagger-ui-dist is only used with set uiIndex option it could be a peerDependency but I am ok with keeping it a normal dependency. Ok I will remove the unneeded dependencies, functions and changelog entries. I should be able to do this tomorrow or the day after. Where should the migration section be documented? |
…d utils, remove unused + update dependencies, add more tests
…stom method support, use all instead of __all
@daffl Since you had not the time yet to review, I fixed a bug and added support for custom methods and path parameters. And renamed __all options I introduced to all to be more align with hooks, where it is also named all. |
…ak), minor changes that occurred while writing tests
Have added many tests with 100% coverage. Did some minor changes and introduced another breaking change, because with #69 tags will always be overwritten, which seems wrong to me. I will do no more changes until requested. |
Awesome. I will make a pre-release today. I also added you as a collaborator to the repository so you can make changes directly. Once it is out would you like to be able to publish new versions to npm as well? |
If you want I can also publish packages to npm. |
Released as v1.0.0, thank you for the great work! |
Summary
This is more or less a rewrite of the library to allow support for swagger v2 and openapi v3, while trying to maintain as much backward compatibility as possible.
Changelog of this Pull Request:
BREAKING:
specs
instead of the root of the config object (in favor of PR #51)service.docs.operations
instead of directly inservice.docs
overwriteTagSpec
option #23ADDED:
FIXED: