Quality of life #68
Merged
Quality of life #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those are great, thank you! Released as v0.5.0 |
This was referenced Jun 8, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize. I was cleaning up my repo and deleted the branch, which closed the PR. here is the same PR as #64
Been trying to dig into Feathers recently, and like it very much so far! Found feathers-swagger, which made things even better. XD Found a bit of missing functionality, though.
As far as I can tell, this should fully backwards compatible.
The id names are fixed to
resourceId(at least in the parameters, though the url is set properly). The type is also fixed atinteger. The parameter name is now set the same way the URL was before, and the type still defaults tointeger, but can be overwritten atdocs.idType.Only the getWithId endpoint had any responses defined, and only the 200, and with no schema. All endpoints have the appropriate responses (as far as I can tell), and off the appropriate schema (with a new list schema defined for the getWithoutId endpoint). Schema refs are also now build with the
taginstead ofmodel, the same place they were previously added if adoc.definitionwas present.List parameters have been added for
$limit,$skip, and$sort.