Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] remove action API, with params #71

Closed
FossPrime opened this issue Nov 7, 2017 · 1 comment
Closed

[feature] remove action API, with params #71

FossPrime opened this issue Nov 7, 2017 · 1 comment

Comments

@FossPrime
Copy link
Contributor

FossPrime commented Nov 7, 2017

Expected behavior

feathers-vuex action API should be remove([id, params]), as the one for the update action is update([id, data, params]) and the feathers service method is remove(id, params)

This prevents passing parameters to remove, disabling softDelete or doing multi-record query deletes.

Actual behavior

The current API is remove(id). parameters are not supported.

Workaround

Use the feathers service method directly.

I'm not sure if this handles soft delete or any sort of complicated remove hook. I assume the record is removed from the store by the id given on the removed service event.

@FossPrime FossPrime changed the title [feature] [feature] full featured remove action API, with params Nov 7, 2017
@FossPrime FossPrime changed the title [feature] full featured remove action API, with params [feature remove action API, with params Nov 7, 2017
@FossPrime FossPrime changed the title [feature remove action API, with params [feature] remove action API, with params Nov 7, 2017
@marshallswain
Copy link
Member

Development for this is complete. This will be available once the models branch has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants