Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not useful error message on NotAuthenticated error #436

Closed
daffl opened this Issue Mar 6, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@daffl
Copy link
Member

daffl commented Mar 6, 2017

When logging in with wrong credentials we get a NotAuthenticated error but the message just says Error which is not a very helpful text to display:

screen shot 2017-03-06 at 12 51 35 pm

feathers-authentication @1.x

@daffl daffl changed the title Not Not useful error message on NotAuthenticated error Mar 7, 2017

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 7, 2017

I recently noticed that on a project as well. I'll look into it today.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 7, 2017

@daffl which way were you logging in? I was getting it when the JWT was expired or when using a custom verifier the credentials didn't exist in the DB.

@daffl

This comment has been minimized.

Copy link
Member Author

daffl commented Mar 7, 2017

Local auth with the wrong username or password.

@daffl

This comment has been minimized.

Copy link
Member Author

daffl commented Mar 9, 2017

It looks the NotAuthenticated error is getting passed an object somewhere that doesn't have a message property which will then just default to Error in https://github.com/feathersjs/feathers-errors/blob/master/src/index.js#L26.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 20, 2017

Closing in favour of tracking here: feathersjs/authentication-local#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.