Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

Not useful error message on NotAuthenticated error #436

Closed
daffl opened this issue Mar 6, 2017 · 5 comments
Closed

Not useful error message on NotAuthenticated error #436

daffl opened this issue Mar 6, 2017 · 5 comments

Comments

@daffl
Copy link
Member

daffl commented Mar 6, 2017

When logging in with wrong credentials we get a NotAuthenticated error but the message just says Error which is not a very helpful text to display:

screen shot 2017-03-06 at 12 51 35 pm

feathers-authentication @1.x
@daffl daffl changed the title Not Not useful error message on NotAuthenticated error Mar 7, 2017
@ekryski
Copy link
Member

ekryski commented Mar 7, 2017 •
edited
Loading

I recently noticed that on a project as well. I'll look into it today.

@ekryski
Copy link
Member

ekryski commented Mar 7, 2017

@daffl which way were you logging in? I was getting it when the JWT was expired or when using a custom verifier the credentials didn't exist in the DB.

@daffl
Copy link
Member Author

daffl commented Mar 7, 2017

Local auth with the wrong username or password.

@daffl
Copy link
Member Author

daffl commented Mar 9, 2017

It looks the NotAuthenticated error is getting passed an object somewhere that doesn't have a message property which will then just default to Error in https://github.com/feathersjs/feathers-errors/blob/master/src/index.js#L26.

@ekryski
Copy link
Member

ekryski commented Mar 20, 2017

Closing in favour of tracking here: feathersjs-ecosystem/authentication-local#10

@ekryski ekryski closed this as completed Mar 20, 2017
@daffl daffl mentioned this issue Jul 20, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daffl @ekryski