This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Fix toLowerCase hook #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you fix the one on line 7, too? |
|
done! |
|
Cool. One more thing I missed, can you revert the version number bump? Our npm release scripts will take care of that. |
|
done too! but 0.3.1 it's still into README changelog. have you a script to bump changelog? |
|
Updating the changelog is fine. @marshallswain It looks like there are no tests for this hook correct? |
|
Correct. I just checked. That one is untested. |
|
Ya I'll add some tests today but that is a good fix. Thanks @enten! It's been on my list in auth repo but I haven't had time to get around to it. Honestly, wasn't sure if anyone would use that hook. |
|
Thanks! I thinks that is it a great helper for fields with an unicity constraint (like username or email). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #74 issue