Skip to content

Commit

Permalink
fix: capital usernames and project names break URL detection (#256)
Browse files Browse the repository at this point in the history
  • Loading branch information
FossPrime committed Apr 30, 2023
1 parent 1eedeb2 commit bb3f9e8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ If your changes involve documentation updates please mention that and link the a

To run this pull request in a clean container visit:
1. Visit https://replit.com/new/github/feathersjs/feathers-chat
2. Run `git pull origin pull/{{id}}/head`
2. Run git pull origin pull/{{id}}/head

Thanks for contributing to Feathers! :heart:
7 changes: 3 additions & 4 deletions .replit
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ npm run dev
compile = """ # Runs before debug too. Lacks custom env vars.
SECONDS=0
FEATHERS_DIR="feathers-chat-ts"
FEATHERS_ORIGIN="https://$REPL_SLUG.$REPL_OWNER.repl.co"
FEATHERS_ORIGIN="https://${REPL_SLUG,,}.${REPL_OWNER,,}.repl.co"
clear
echo [compile]

Expand Down Expand Up @@ -57,7 +57,7 @@ fi
INDEX_TS="$FEATHERS_DIR/src/index.ts"
if ! grep -q "console.time" "$INDEX_TS"; then
sed -i "/Feathers app listening on /a \\
\\ logger.info(\\`Remote: \\${process.env.FEATHERS_ORIGIN}\\`)\\n\\
\\ logger.info(\\`Remote: \\${process.env.FEATHERS_ORIGIN?.toLowerCase()}\\`)\\n\\
console.timeEnd('App startup time')" "$INDEX_TS"

sed -i "1i console.time('App startup time')" "$INDEX_TS"
Expand Down Expand Up @@ -93,7 +93,7 @@ PATH = "/home/runner/$REPL_SLUG/.config/npm/node_global/bin:/home/runner/$REPL_S
EDITOR = "replit-git-editor"
npm_config_prefix = "/home/runner/$REPL_SLUG/.config/npm/node_global"
HOSTNAME = "0.0.0.0"
FEATHERS_ORIGIN = "https://$REPL_SLUG.$REPL_OWNER.repl.co"
FEATHERS_ORIGIN = "https://${REPL_SLUG}.${REPL_OWNER}.repl.co"
NODE_OPTIONS = "--max_old_space_size=384"

# Enables Secrets and Auth, without the Replit packager
Expand Down Expand Up @@ -153,5 +153,4 @@ support = true

[debugger.interactive.launchMessage.arguments.env]
PORT = 9000
FEATHERS_ORIGIN = "https://$REPL_SLUG.$REPL_OWNER.repl.co:9000"

0 comments on commit bb3f9e8

Please sign in to comment.