Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for a testing guide #79

Merged
merged 1 commit into from
Jan 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -108,5 +108,6 @@ $RECYCLE.BIN/
*.lnk

# Others
test/data/
data/
tmp/
3 changes: 3 additions & 0 deletions config/test.json
@@ -0,0 +1,3 @@
{
"nedb": "../test/data"
}
66 changes: 66 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
Expand Up @@ -25,7 +25,8 @@
"test": "npm run eslint && npm run mocha",
"eslint": "eslint src/. test/. --config .eslintrc.json",
"start": "node src/",
"mocha": "mocha test/ --recursive --exit"
"clean": "shx rm -rf test/data/",
"mocha": "npm run clean && NODE_ENV=test mocha test/ --recursive --exit"
},
"dependencies": {
"@feathersjs/authentication": "^2.0.1",
Expand All @@ -49,6 +50,7 @@
"feathers-memory": "^2.1.0",
"mocha": "^4.0.1",
"request": "^2.83.0",
"request-promise": "^4.2.2"
"request-promise": "^4.2.2",
"shx": "^0.2.2"
}
}
2 changes: 1 addition & 1 deletion src/services/messages/messages.hooks.js
Expand Up @@ -6,7 +6,7 @@ const populateUser = require('../../hooks/populate-user');

module.exports = {
before: {
all: [ authenticate('jwt') ],
all: [authenticate('jwt')],
find: [],
get: [],
create: [processMessage()],
Expand Down
23 changes: 23 additions & 0 deletions test/services/messages.test.js
Expand Up @@ -7,4 +7,27 @@ describe('\'messages\' service', () => {

assert.ok(service, 'Registered the service');
});

it('creates and processes message, adds user information', async () => {
// Create a new user we can use for testing
const user = await app.service('users').create({
email: 'messagetest@example.com',
password: 'supersecret'
});

// The messages service call params (with the user we just created)
const params = {user };
const message = await app.service('messages').create({
text: 'a test',
additional: 'should be removed'
}, params);

assert.equal(message.text, 'a test');
// `userId` should be set to passed users it
assert.equal(message.userId, user._id);
// Additional property has been removed
assert.ok(!message.additional);
// `user` has been populated
assert.deepEqual(message.user, user);
});
});
25 changes: 25 additions & 0 deletions test/services/users.test.js
Expand Up @@ -7,4 +7,29 @@ describe('\'users\' service', () => {

assert.ok(service, 'Registered the service');
});

it('creates a user, encrypts password and adds gravatar', async () => {
const user = await app.service('users').create({
email: 'test@example.com',
password: 'secret'
});

// Verify Gravatar has been set to what we'd expect
assert.equal(user.avatar, 'https://s.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0?s=60');
// Makes sure the password got encrypted
assert.ok(user.password !== 'secret');
});

it('removes password for external requests', async () => {
// Setting `provider` indicates an external request
const params = { provider: 'rest' };

const user = await app.service('users').create({
email: 'test2@example.com',
password: 'secret'
}, params);

// Make sure password has been remove
assert.ok(!user.password);
});
});