fix(transport-commons): Properly delete route data (#3433)

feathersjs · Feb 25, 2024 · af01bdb · af01bdb
1 parent c9511d9
commit af01bdb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/packages/transport-commons/src/routing/router.ts b/packages/transport-commons/src/routing/router.ts
@@ -57,6 +57,7 @@ export class RouteNode<T = any> {
 
   remove(path: string[]) {
     if (path.length === this.depth) {
+      delete this.data
       return
     }
 

diff --git a/packages/transport-commons/test/routing/router.test.ts b/packages/transport-commons/test/routing/router.test.ts
@@ -118,4 +118,22 @@ describe('router', () => {
     r.remove('/hello/here/thing')
     assert.ok(!r.root.hasChildren)
   })
+
+  it('re-initialize a service with children. (#3432)', () => {
+    const r = new Router<string>()
+
+    r.insert('/hello', 'one')
+    r.insert('/hello/world', 'else')
+
+    assert.deepStrictEqual(r.lookup('hello'), { params: { }, data: 'one' })
+
+    r.remove('/hello')
+
+    assert.deepStrictEqual(r.lookup('hello/world'), { params: {}, data: 'else' })
+
+    r.insert('/hello', 'two')
+
+    assert.deepStrictEqual(r.lookup('hello'), { params: { }, data: 'two' })
+    assert.deepStrictEqual(r.lookup('hello/world'), { params: {}, data: 'else' })
+  })
 })